Open
Conversation
Member
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
Added checkbox option to apply database changes immediately instead of waiting for maintenance window. Changes: - Created ApplyImmediatelyCheckbox component with integrated warning messages - Integrated checkbox in Settings > General (version changes) - Integrated checkbox in Settings > Resources (instance type and storage changes) - Single checkbox appears when any managed database setting is changed - Warning message adapts dynamically when checkbox is checked - Added apply_immediately field to form payloads UX: Single warning callout that expands with additional warning when "apply immediately" is checked.
Guimove
force-pushed
the
feat/database-apply-immediately
branch
from
6397537 to
052ac0e
Compare
The component uses useFormContext() which requires a FormProvider to be present in tests.
- Import DatabaseEditRequest type explicitly - Type return value as Partial<DatabaseEditRequest> - Simplify logic by constructing clean object instead of cloning and mutating - Remove unnecessary object cloning and mutation - More functional and type-safe approach
- Update qovery-typescript-axios from v1.1.819 to v1.1.822 - Includes apply_immediately field in DatabaseEditRequest and Database types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue:
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release